Skip to content

fix(ui): persist authentication cookie beyond current browser session - #11066

Draft
hi-ogawa wants to merge 1 commit into
vitest-dev:mainfrom
hi-ogawa:fix/ui-persistent-cookie
Draft

fix(ui): persist authentication cookie beyond current browser session#11066
hi-ogawa wants to merge 1 commit into
vitest-dev:mainfrom
hi-ogawa:fix/ui-persistent-cookie

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Currently the browser authentication cookie is currently session-only, so after restarting the browser or pc, auto-opened UI url always fails and it require opening the token URL manually again.

I didn't intended that way, so this PR fixes the browser cookie lifetime to be longer than current session by specifying "max age". I'm not familiar with exact cookie semantics, agents dug up some references:

https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie#expiresdate

If unspecified, the cookie becomes a session cookie. A session finishes when the client shuts down, after which the session cookie is removed.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
@netlify

netlify Bot commented Aug 26, 2026

Copy link
Copy Markdown

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eea095d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a8e771d06183d0008836dcd
😎 Deploy Preview https://deploy-preview-11066--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant